Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lockdown: not working with rollup #943

Open
Jack-Works opened this issue Nov 26, 2021 · 0 comments · Fixed by Rich-Harris/magic-string#194
Open

lockdown: not working with rollup #943

Jack-Works opened this issue Nov 26, 2021 · 0 comments · Fixed by Rich-Harris/magic-string#194
Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@Jack-Works
Copy link
Contributor

Throws error when running with rollup.

image

A reproduction:

In normal web page:

image

With lockdown:

image

Is this a lockdown bug or I should report it to rollup/magic-string?
@Jack-Works Jack-Works reopened this Nov 26, 2021
@Jack-Works Jack-Works mentioned this issue Nov 26, 2021
Merged
@kriskowal kriskowal added the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use defineProperty for appending prop in storeName
2 participants
@kriskowal @Jack-Works