fix: use defineProperty for appending prop in storeName
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: use define property
|
Can you please explain this in more detail? Why is this fix needed? |
In a secured environment, all built-in prototypes are frozen, including Object.prototype.
In this case, |
|
@Jack-Works Can you give permission for maintainers to edit this PR (here should be a check box on this page)? We can't rebase this PR to the latest branch. |
|
@antfu I didn't find that check box but I manually merge with the latest commit |
antfu
changed the title
storeName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close endojs/endo#943