-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Babel 7.23 #1893
Upgrade Babel 7.23 #1893
Conversation
Nit title: 7.23 not 2.23 |
4e9c2c4
to
a19939b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run a npx yarn-deduplicate
@@ -37,14 +37,12 @@ | |||
".": { | |||
"types": "./types.d.ts", | |||
"import": "./index.js", | |||
"require": "./dist/ses.cjs", | |||
"types": "./types.d.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "types" changes seem unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. This was a byproduct of running ./scripts/set-versions.sh
, which went ahead and removed the duplicate key from this package.json
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and I’m retaining an individual commit for this change so it’s easy to identify/remove/move. I’ll accommodate your preference. Mine is to preserve the commit and save time.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I missed the duplication!
a19939b
to
2be21c8
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After dedup, the diff of the yarn.lock looks as expected. If tests pass, we should be good to go.
PS: to double check, you ran yarn install
after npx yarn-deduplicate
to make sure the yarn.lock
was stable?
@@ -37,14 +37,12 @@ | |||
".": { | |||
"types": "./types.d.ts", | |||
"import": "./index.js", | |||
"require": "./dist/ses.cjs", | |||
"types": "./types.d.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I missed the duplication!
I did not and it was not stable. Please see the new commit. |
closes: #1846
Description
This should put #1846 to bed. The latest patch releases for Babel have addressed the property override mistake observed while bundling under lockdown.
As evidence, integrating this branch into Agoric SDK Agoric/agoric-sdk#8514 obviates the need to run the bundler with overrideTaming: severe.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations