refactor(daemon): Consolidate interface definitions and cleanup #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
bb4eb80
to
5945434
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
b589c8c
to
eb91183
Compare
rekmarks
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Hm, why not interfaces/index.js and interfaces/web.js? Indeed, why a separate file at all?
There was a problem hiding this comment.
I loathe the Node.js index.js lookup because it assumes a search path that doesn’t translate to the web. Of course, that’s immaterial since we’re never going to be free of a bundler or import-map, but I prefer to live in the make-believe so as to be ready for change.
I separated interfaces/web.js because these interfaces are not canon to the daemon itself but a contract between the web server and client, and the web client should shake out the interfaces it doesn’t need in its bundle.
| type: 'known-peers-store', | ||
| }); | ||
| // We generate formulas for some entities that are presumed to exist | ||
| // because they are parts of the daemon's root object. |
There was a problem hiding this comment.
Suggested change
| // because they are parts of the daemon's root object. | |
| // because they are part of the daemon's root object. |
There was a problem hiding this comment.
I think the cardinality of “formulas”, “entities”, “are”, and “parts” should agree here.
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
5945434
to
34d45cd
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
eb91183
to
87fb53d
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
34d45cd
to
7a544bf
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
87fb53d
to
04ab5a9
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
7a544bf
to
d477162
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
04ab5a9
to
a800bb4
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
d477162
to
2557dbd
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
a800bb4
to
19b7de5
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
2557dbd
to
2347a23
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
19b7de5
to
30cd2d6
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
2347a23
to
766381e
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
30cd2d6
to
0ec9aee
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
766381e
to
b0f81a1
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
0ec9aee
to
6d33438
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
b0f81a1
to
b0c7b35
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
6d33438
to
d4548a9
Compare
kriskowal
force-pushed
the
kriskowal-daemon-at-import
branch
from
b0c7b35
to
821c9d9
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
d4548a9
to
ea02cfa
Compare
kriskowal
force-pushed
the
kriskowal-daemon-cleanup
branch
from
ea02cfa
to
ddc0825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These individually reviewable commits consolidate some recurring patterns, move interface definitions into a separate module, adds more explanatory comments, and fixes some lingering errors.