Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Yarn's pnpm linker #2327

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

use Yarn's pnpm linker #2327

wants to merge 6 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 21, 2024

unsolicited

Description

Use the pnpm linker mode

Faster than nodeLinker and detects some ghost dependencies (as evidenced by all the dependencies this PR adds to get tests passing)

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

For the changelog

Testing Considerations

CI

Compatibility Considerations

none

Upgrade Considerations

No changes to package consumption but should have this for developers

  • Update NEWS.md for user-facing changes.

@turadg
Copy link
Member Author

turadg commented Oct 4, 2024

@kriskowal any ideas on how to get test262-runner to build? I tried yarn add eshost but it still couldn't find the dependencies that that package brought in. Seems something specific to how test262-harness works.

@kriskowal
Copy link
Member

  1. I love this change. I love everything about it, but especially revealing ghost dependencies. I hold Ryah personally accountable for allowing ghost dependencies. Hi, Ryah.
  2. I might delete test262-runner soon. I have a hardened262 package in my stack for Using XS native Compartments for Agoric Vat Workers #400 which will be up for review two reviews currently in flight. So, maybe this goes away with no more effort from you.
  3. The problem is not a ghost dependency from test262-harness on eshost https://github.com/tc39/test262-harness/blob/master/package.json
  4. That’s odd. I’ll have to circle back and attempt to reproduce the issue locally, and poke around in the node_modules tree to see why it can’t find node_modules/eshost from any ancestor directory from the realpath for test262-harness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants