-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use yarn for cross-workspace script running #2565
Conversation
This might break agoric-sdk integrations with Endo. We'll need to run some integration on the agoric-sdk side before this can merge |
@mhofman unsure how this would affect |
unfortunately, yarn did not solve the main issue i wanted it to, indicating which workspaces failed |
I encountered a "cover" CI issue twice in a row (once on first run, then on retry failed). Retrying all fixed it, so I suspect something to do with the cache (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a way this could break agoric-sdk's Endo integration but here's a test to be sure: Agoric/agoric-sdk#9385
51dbe49
to
1b27580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reducing reliance on Lerna.
Code looks good, CI green here and in agoric-sdk integration branch
1b27580
to
92137e6
Compare
(rebased) |
Migrates cross-workspace script running to
yarn workspaces
.lerna
is still used for:node_modules
)etc: