Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yarn for cross-workspace script running #2565

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Oct 3, 2024

Migrates cross-workspace script running to yarn workspaces.

lerna is still used for:

  • ci prepack check after packing
  • publishing
  • cleaning (removing all node_modules)

etc:

  • added test:xs script in root
  • deprecated "yarn run update" in root

@kumavis kumavis requested a review from turadg October 3, 2024 03:22
@mhofman
Copy link
Contributor

mhofman commented Oct 3, 2024

This might break agoric-sdk integrations with Endo. We'll need to run some integration on the agoric-sdk side before this can merge

@kumavis
Copy link
Member Author

kumavis commented Oct 3, 2024

@mhofman unsure how this would affect agoric-sdk. lerna is not removed and the change is primarily how the scripts are invoked. where can i learn more?

@kumavis
Copy link
Member Author

kumavis commented Oct 3, 2024

unfortunately, yarn did not solve the main issue i wanted it to, indicating which workspaces failed
yarnpkg/berry#6535

@kumavis kumavis requested a review from mhofman October 3, 2024 07:22
@kumavis
Copy link
Member Author

kumavis commented Oct 3, 2024

I encountered a "cover" CI issue twice in a row (once on first run, then on retry failed). Retrying all fixed it, so I suspect something to do with the cache (?)
unsure what else it could be. race condition?

Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a way this could break agoric-sdk's Endo integration but here's a test to be sure: Agoric/agoric-sdk#9385

scripts/migrate-test-names.mjs Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kumavis kumavis force-pushed the yarn-workspaces-for-scripts branch 2 times, most recently from 51dbe49 to 1b27580 Compare October 3, 2024 23:26
@kumavis kumavis requested a review from turadg October 3, 2024 23:45
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing reliance on Lerna.

Code looks good, CI green here and in agoric-sdk integration branch

@kumavis kumavis force-pushed the yarn-workspaces-for-scripts branch from 1b27580 to 92137e6 Compare October 4, 2024 20:15
@kumavis
Copy link
Member Author

kumavis commented Oct 4, 2024

(rebased)

@kumavis kumavis enabled auto-merge (rebase) October 4, 2024 20:21
@kumavis kumavis merged commit e6c52ea into master Oct 4, 2024
15 checks passed
@kumavis kumavis deleted the yarn-workspaces-for-scripts branch October 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants