fix(ses): Add HandledPromise to the whitelist #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
reviewed
Aug 13, 2020
kriskowal
previously requested changes
Aug 13, 2020
packages/ses/src/whitelist.js
Outdated
| @@ -59,6 +59,7 @@ export const universalPropertyNames = { | |||
| Map: 'Map', | |||
| Number: 'Number', | |||
| Object: 'Object', | |||
| HandledPromise: 'HandledPromise', // TODO: Until Promise.delegate. | |||
There was a problem hiding this comment.
More information on the TODO will make it more clear when TODO can be removed.
|
Please add an entry to NEWS.md. |
michaelfig
force-pushed
the
mfig/whitelist-handled-promise
branch
from
72ac6be
to
c571a74
Compare
michaelfig
force-pushed
the
mfig/whitelist-handled-promise
branch
from
ba2a9bb
to
c60b7a6
Compare
Done. |
kriskowal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix until lockdown gets a more disciplined way of updating the whitelist with vetted shims. In any event, it is a step toward
Promise.delegate, but that standard hasn't yet been implemented in@agoric/eventual-send/shim.@kriskowal Please update and release a new patch version of
ses, so that we can use this in agoric-sdk.