Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added visual effect to speed limiter #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AhmedOsama
Copy link

Speed limiter now shows in Red when enabled on mobile devices


#mobile-footer .links li .speed_limit_mode.active {
background: transparent url('images/speed.png') no-repeat -34px -3px !important;
width: 32px !important;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it necessary to redefine the width and height?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because its a sprite image, 1 image for both icons just to avoid any old
browser glitches

On Fri, Sep 26, 2014 at 8:37 AM, Frank Prößdorf [email protected]
wrote:

In css/mobile.css:

@@ -250,8 +250,15 @@ footer {
}

#mobile-footer .links li .speed_limit_mode {

  • background: transparent url(images/speed_mobile.png) no-repeat 0 0;
  • background-size: 100%;
  • background: transparent url('images/speed.png') no-repeat -34px -42px;
  • width: 32px;
  • height: 32px;
    +}

+#mobile-footer .links li .speed_limit_mode.active {

  • background: transparent url('images/speed.png') no-repeat -34px -3px !important;
  • width: 32px !important;

why is it necessary to redefine the width and height?


Reply to this email directly or view it on GitHub
https://github.com/endor/kettu/pull/104/files#r18075493.

@endor
Copy link
Owner

endor commented Sep 26, 2014

Thanks! That's a good idea.

Could you please remove the old image though?

Also, if you have the time, it'd be great if you could do the same for the compact mode, statistics, preferences and add torrent icons (:

@AhmedOsama
Copy link
Author

yea sure i'll have the old image removed and work on the compact mode, statistics, preferences and add torrent icons sometime later tomorrow (:

@endor
Copy link
Owner

endor commented Oct 1, 2014

@AhmedOsama still doing that? (:

@AhmedOsama
Copy link
Author

really busy these days ... unfortunately and we are about to have a civic holiday here so hopefully sometime next week if everything goes well

@Mariappan
Copy link
Contributor

@AhmedOsama Thank you very much for this commit. I was exactly looking for the same. Since on my mobile, I confused myself a lot to know whether the speed limiter is set or not.

@endor Thanks for this wonderful project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants