licensedevice plugin: Implement docker-based Notifier #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor-fixes
force-pushed
the
nomad_plugin_epoll_impl
branch
3 times, most recently
from
b07a85c
to
73d52ea
Compare
minor-fixes
changed the title
This change ends up being a sort of "rest of the owl" change to produce
something nominally demo-able. It includes:
* SQL scripts that initialize a DB with dummy data
* Docker Notifier implementation that listens for containers to be
started/killed, and looks at their environment vars to deduce which
licenses it uses
* Various other bug fixes and improvements that allow the thing to
actually work, be demoed.
There are still lots of glaring holes to be fixed in future changes
and/or a rewrite to a non-experimental dir.
Tested:
* ran locally 2x with:
```
NOMAD_PLUGIN_MAGIC_COOKIE=e4327c2e01eabfd75a8a67adb114fb34a757d57eee7728d857a8cec6e91a7255 \
bazel run \
//experimental/nomad_resource_plugin/licensedevice/cmd/nomad_license_plugin \
-- \
'postgresql://<USER>:<URL_ENCODED_PW>@<HOSTNAME>:5432/cj_stage' \
'license_state' \
'scott-workstation-2'
```
(the last arg is the local hostname, which is changed between the two
instances
* on one instance, ran `grpc_cli call unix://<SOCKET_FILE>
hashicorp.nomad.plugins.device.DevicePlugin.Fingerprint ''` to print
out streaming Fingerprint responses (plugin prints out the socket file
to use on start)
* on the other instance, made a `Reserve` call, saw Fingerprint respond
on the first instance as unhealthy
* ran `docker run -it -e LICENSEPLUGIN_RESERVED_IDS=example_ax_1 ubuntu
/bin/bash` to simulate a workload starting; saw DB get updated and
more Fingerprint responses
* exited aforementioned container; saw DB get updated and more
Fingerprint responses
minor-fixes
force-pushed
the
nomad_plugin_epoll_impl
branch
from
73d52ea
to
0147503
Compare
mhallmark
approved these changes
Jan 11, 2024
| @@ -32,5 +32,17 @@ | |||
| }, | |||
| "go.useLanguageServer": true, | |||
| "go.lintOnSave": "off", | |||
| "go.vetOnSave": "off" | |||
| "go.vetOnSave": "off", | |||
| "sqltools.connections": [ | |||
There was a problem hiding this comment.
i dont think these were meant to get in this PR? seems like its not a common connection for all the people in the org
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| break loop |
There was a problem hiding this comment.
unless im missing something...
the jump back to loop will cause this case to get called again no? and at this point it would either cause an infinite loop (assuming the Done() channel is closed), or never reach this case again because the Done() channel is drained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ends up being a sort of "rest of the owl" change to produce
something nominally demo-able. It includes:
started/killed, and looks at their environment vars to deduce which
licenses it uses
actually work, be demoed.
There are still lots of glaring holes to be fixed in future changes
and/or a rewrite to a non-experimental dir.
Tested:
ran locally 2x with:
(the last arg is the local hostname, which is changed between the two
instances
grpc_cli call unix://<SOCKET_FILE> hashicorp.nomad.plugins.device.DevicePlugin.Fingerprint ''to printout streaming Fingerprint responses (plugin prints out the socket file
to use on start)
Reservecall, saw Fingerprint respondon the first instance as unhealthy
docker run -it -e LICENSEPLUGIN_RESERVED_IDS=example_ax_1 ubuntu /bin/bashto simulate a workload starting; saw DB get updated andmore Fingerprint responses
Fingerprint responses