astore: Move combined server binary to dedicated dir #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to split astore and auth servers into two binaries, but there is no room to do so while still respecting Go structure rules. This change simply moves main.go into its own dir, so that we can create alternate split binaries in separate dirs in follow-on PRs. Tested: builds only Not tested: If AppEngine deployment works when target is moved to a different/nested dir Jira: INFRA-6592
minor-fixes
force-pushed
the
infra/6592_move_astore_auth
branch
from
80c6d73
to
646e7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to split astore and auth servers into two binaries, but there is no room to do so while still respecting Go structure rules. This change simply moves main.go into its own dir, so that we can create alternate split binaries in separate dirs in follow-on PRs.
Tested: builds only
Not tested: If AppEngine deployment works when target is moved to a different/nested dir
Jira: INFRA-6592