astore: Split out auth main.go #966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous PR moved the bulk of the files from astore to auth directory with the intention of splitting out the auth server from the astore binary. Some files were moved to the auth directory that astore still needed like assets and templates, so those directories were copied back to astore. This makes duplicate auth/server/assets and astore/server/assets directories. Some of these assets may be removed from either directory if they arent needed. The main part of this PR creates a new main.go under auth/server so auth and astore can be deployed separately. Testing - neither of these binaries have been fully tested. I was able to get the astore server running locally, but wasn't able to start auth (was missing some flag values).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR moved the bulk of the files from astore to auth directory with the intention of splitting out the auth server from the astore binary.
Some files were moved to the auth directory that astore still needed like assets and templates, so those directories were copied back to astore. This makes duplicate auth/server/assets and astore/server/assets directories. Some of these assets may be removed from either directory if they arent needed.
The main part of this PR creates a new main.go under auth/server so auth and astore can be deployed separately.
Testing - neither of these binaries have been fully tested. I was able to get the astore server running locally, but wasn't able to start auth (was missing some flag values).