[local_auth] Fix incorrect switch fallthrough (flutter#3473)

engine-flutter-autoroll · Jan 30, 2021 · 35847e4 · 35847e4
1 parent 9764636
commit 35847e4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/packages/local_auth/CHANGELOG.md b/packages/local_auth/CHANGELOG.md
@@ -2,10 +2,14 @@
 
 * Allow pin, passcode, and pattern authentication with `authenticate` method
 * **Breaking change**. Parameter names refactored to use the generic `biometric` prefix in place of `fingerprint` in the `AndroidAuthMessages` class
-  * `fingerprintHint` is now `biometricHint`  
-  * `fingerprintNotRecognized`is now `biometricNotRecognized`  
-  * `fingerprintSuccess`is now `biometricSuccess`  
-  * `fingerprintRequiredTitle` is now `biometricRequiredTitle` 
+  * `fingerprintHint` is now `biometricHint`
+  * `fingerprintNotRecognized`is now `biometricNotRecognized`
+  * `fingerprintSuccess`is now `biometricSuccess`
+  * `fingerprintRequiredTitle` is now `biometricRequiredTitle`
+
+## 1.0.0-nullsafety.4
+
+* Fix incorrect error handling switch case fallthrough.
 
 ## 1.0.0-nullsafety.3
 
@@ -203,4 +207,4 @@
 
 ## 0.0.1
 
-* Initial release of local authentication plugin.
+* Initial release of local authentication plugin.
diff --git a/...s/local_auth/android/src/main/java/io/flutter/plugins/localauth/AuthenticationHelper.java b/...s/local_auth/android/src/main/java/io/flutter/plugins/localauth/AuthenticationHelper.java
@@ -138,6 +138,7 @@ public void onAuthenticationError(int errorCode, CharSequence errString) {
           return;
         }
         completionHandler.onError("NotAvailable", "Security credentials not available.");
+        break;
       case BiometricPrompt.ERROR_NO_SPACE:
       case BiometricPrompt.ERROR_NO_BIOMETRICS:
         if (promptInfo.isDeviceCredentialAllowed()) return;

diff --git a/packages/local_auth/pubspec.yaml b/packages/local_auth/pubspec.yaml
@@ -1,8 +1,8 @@
 name: local_auth
-description: Flutter plugin for Android and iOS devices to allow local 
+description: Flutter plugin for Android and iOS devices to allow local
   authentication via fingerprint, touch ID, face ID, passcode, pin, or pattern.
 homepage: https://github.com/flutter/plugins/tree/master/packages/local_auth
-version: 1.0.0-nullsafety.3
+version: 1.0.0-nullsafety.4
 
 flutter:
   plugin: