Skip to content

Commit

Permalink
[fuchsia] Send trace events to system tracing on all configurations (f…
Browse files Browse the repository at this point in the history
…lutter#20974)

This change reverts flutter/engine#15900.  The
design of the expected consumer of the original PR changed, and the
feature ended up going unused.  Since the unexpected difference in trace
event routing behavior has mostly ended up as a source of confusion,
change things back to route trace events to Fuchsia system tracing on
all configurations.
  • Loading branch information
nathanrogersgoogle authored Sep 3, 2020
1 parent 6e8930b commit 68b7b84
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 1 addition & 2 deletions runtime/dart_vm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,7 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
args.push_back(old_gen_heap_size_args.c_str());
}

#if defined(OS_FUCHSIA) && \
(FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_PROFILE)
#if defined(OS_FUCHSIA)
PushBackAll(&args, kDartFuchsiaTraceArgs, fml::size(kDartFuchsiaTraceArgs));
PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs));
#endif
Expand Down
2 changes: 0 additions & 2 deletions shell/platform/fuchsia/dart_runner/dart_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ const char* kDartVMArgs[] = {
// addressed.
"--no_causal_async_stacks",

#if !defined(FLUTTER_PROFILE)
"--systrace_timeline",
#endif
"--timeline_streams=Compiler,Dart,Debugger,Embedder,GC,Isolate,VM",

#if defined(AOT_RUNTIME)
Expand Down

0 comments on commit 68b7b84

Please sign in to comment.