Skip to content

Commit

Permalink
Reverts "Introduce ChipAnimationStyle to override default chips ani…
Browse files Browse the repository at this point in the history
…mations durations (#149245)" (#149847)

Reverts: flutter/flutter#149245
Initiated by: QuncCccccc
Reason for reverting: the newly-added unit test might cause the red tree
Original PR Author: TahaTesser

Reviewed By: {bleroux, Piinks}

This change reverts the following previous change:
fixes [Custom backgroundColor on Chip makes it flicker between state transitions](flutter/flutter#146730)

### Example preview
![Screenshot 2024-05-28 at 17 40 00](https://github.com/flutter/flutter/assets/48603081/b9117ed2-5afa-4d65-93ae-aa866772ffa1)

https://github.com/flutter/flutter/assets/48603081/a4949ce7-f38b-4251-8201-ecc570ec447c
  • Loading branch information
auto-submit[bot] authored Jun 6, 2024
1 parent 32da263 commit 6f2d0be
Show file tree
Hide file tree
Showing 12 changed files with 4 additions and 832 deletions.

This file was deleted.

This file was deleted.

5 changes: 0 additions & 5 deletions packages/flutter/lib/src/material/action_chip.dart
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
this.surfaceTintColor,
this.iconTheme,
this.avatarBoxConstraints,
this.chipAnimationStyle,
}) : assert(pressElevation == null || pressElevation >= 0.0),
assert(elevation == null || elevation >= 0.0),
_chipVariant = _ChipVariant.flat;
Expand Down Expand Up @@ -146,7 +145,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
this.surfaceTintColor,
this.iconTheme,
this.avatarBoxConstraints,
this.chipAnimationStyle,
}) : assert(pressElevation == null || pressElevation >= 0.0),
assert(elevation == null || elevation >= 0.0),
_chipVariant = _ChipVariant.elevated;
Expand Down Expand Up @@ -197,8 +195,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
final IconThemeData? iconTheme;
@override
final BoxConstraints? avatarBoxConstraints;
@override
final ChipAnimationStyle? chipAnimationStyle;

@override
bool get isEnabled => onPressed != null;
Expand Down Expand Up @@ -237,7 +233,6 @@ class ActionChip extends StatelessWidget implements ChipAttributes, TappableChip
surfaceTintColor: surfaceTintColor,
iconTheme: iconTheme,
avatarBoxConstraints: avatarBoxConstraints,
chipAnimationStyle: chipAnimationStyle,
);
}
}
Expand Down
Loading

0 comments on commit 6f2d0be

Please sign in to comment.