Tiny improvement of RouteSettings display (#114481)

* impl * Update packages/flutter/lib/src/widgets/navigator.dart Co-authored-by: chunhtai <[email protected]> * Update navigator_test.dart Co-authored-by: chunhtai <[email protected]>
engine-flutter-autoroll · Nov 18, 2022 · 9807761 · 9807761
1 parent 4593917
commit 9807761
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/widgets/navigator.dart b/packages/flutter/lib/src/widgets/navigator.dart
@@ -548,7 +548,7 @@ class RouteSettings {
   final Object? arguments;
 
   @override
-  String toString() => '${objectRuntimeType(this, 'RouteSettings')}("$name", $arguments)';
+  String toString() => '${objectRuntimeType(this, 'RouteSettings')}(${name == null ? 'none' : '"$name"'}, $arguments)';
 }
 
 /// Describes the configuration of a [Route].

diff --git a/packages/flutter/test/widgets/navigator_test.dart b/packages/flutter/test/widgets/navigator_test.dart
@@ -3935,6 +3935,16 @@ void main() {
     );
     expect(policy, isA<ReadingOrderTraversalPolicy>());
   });
+
+  group('RouteSettings.toString', () {
+    test('when name is not null, should have double quote', () {
+      expect(const RouteSettings(name: '/home').toString(), 'RouteSettings("/home", null)');
+    });
+
+    test('when name is null, should not have double quote', () {
+      expect(const RouteSettings().toString(), 'RouteSettings(none, null)');
+    });
+  });
 }
 
 typedef AnnouncementCallBack = void Function(Route<dynamic>?);