Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build process to Rollup #130

Merged
merged 8 commits into from
May 12, 2019
Merged

Upgrade build process to Rollup #130

merged 8 commits into from
May 12, 2019

Conversation

bigtimebuddy
Copy link
Contributor

@bigtimebuddy bigtimebuddy commented May 10, 2019

Fixes #129

The goal of this refactor was to restructure the project to be a little bit more modern and support tree-shaking for bundlers like Webpack. That's only possible using ES modules. No logic was touched for the loading itself, just the docs and how the project is assembled and built.

Changes

  • Dropped use of watchify/browserify and replaced with Rollup
  • Generates CommonJS, ESM (bundlers-only) and IIFE (browser-only) builds
  • Fixes issues with documentation properties not showing up
  • Updated dependencies

Breaking Changes

  • Renamed the bundled middleware functions and updated the README to describe usage
  • Removes the squirrelly exports which mixed default and named exports (generally should do one or the other) The docs reflect the exports via the node module. In the browser everything is hung on the Loader global object.

@englercj
Copy link
Owner

This is pretty awesome, thanks for all this work @bigtimebuddy! I will give it a read through this weekend and see if we can't do a major release soon.

Thanks again for all the effort.

@bigtimebuddy
Copy link
Contributor Author

No problem 👍 most of this follows a build pattern similar to the new PixiJS packages so it was pretty straightforward

@englercj englercj merged commit 60539c6 into englercj:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM module & TS typings
2 participants