Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the
Qt::ItemFlags
constructor for int was deprecated, so neither0
nornullptr
were correct for invalid model indexes. The correct replacement isQt::NoItemFlags
that is assigned0
in the enum. Second, apparently I made a mistake when I added the simple about dialog usingQMessageBox
in that I was passing0
for the window flags parameter, then later changed it tonullptr
because I confused it with the parent parameter. That's not good because it needed theQt::Dialog
flag it gets by default, so I just removed that argument from the call.https://doc.qt.io/qt-5/qmessagebox.html#QMessageBox-1