Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flag Warnings #162

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix Flag Warnings #162

merged 1 commit into from
Aug 26, 2020

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Aug 26, 2020

First, the Qt::ItemFlags constructor for int was deprecated, so neither 0 nor nullptr were correct for invalid model indexes. The correct replacement is Qt::NoItemFlags that is assigned 0 in the enum. Second, apparently I made a mistake when I added the simple about dialog using QMessageBox in that I was passing 0 for the window flags parameter, then later changed it to nullptr because I confused it with the parent parameter. That's not good because it needed the Qt::Dialog flag it gets by default, so I just removed that argument from the call.
https://doc.qt.io/qt-5/qmessagebox.html#QMessageBox-1

@RobertBColton RobertBColton merged commit 739ed07 into master Aug 26, 2020
@RobertBColton RobertBColton deleted the fix-flag-warnings branch August 26, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants