Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TreeModel::MakeResourcePath and ResourceMoved. #199

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

JoshDreamland
Copy link
Member

These should enable moving resources on disk in response to moving that resource in the tree.

We may need to revisit the TreeModel to make it use a custom wrapper of the TreeNode proto. This would save us some headache keeping track of the tree structure, and also where the files live on disk, when they were last saved, etc.

These should enable moving resources on disk in response to moving that resource in the tree.

We may need to revisit the TreeModel to make it use a custom wrapper of the TreeNode proto. This would save us some headache keeping track of the tree structure, and also where the files live on disk, when they were last saved, etc.
Copy link
Contributor

@RobertBColton RobertBColton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It "looks" correct; it's what you're trying to do. I'm still not sure it's actually necessary though, but I'd probably suggest a better alternative once I see how it's actually used. Also, programmatic changes in the model are not reflected by this change.

@JoshDreamland
Copy link
Member Author

We need to grow this model out to be the authoritative source for that.

@JoshDreamland JoshDreamland merged commit 6486b33 into master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants