Sprites #85
Merged
Sprites #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Models/RepeatedStringModel.cpp
Outdated
| emit endResetModel(); | ||
| } | ||
|
|
||
| void RepeatedStringModel::SwapBack(int left, int part, int right) { |
There was a problem hiding this comment.
You can probably inherit this, among other methods here, from a base class, using CRTP if necessary.
| }) | ||
| } | ||
| }; | ||
| { |
There was a problem hiding this comment.
oh my god did clang do this?
Models/ProtoModel.cpp
Outdated
| for (int j = 0; j < refl->FieldSize(*protobuf, field); j++) { | ||
| subModels.strings[field->number()].append(QString::fromStdString(refl->GetRepeatedString(*protobuf, field, j))); | ||
| } | ||
| if (field->name() == "subimages") |
There was a problem hiding this comment.
Good news: we have a file_type extension for this, now. Anyway, like I said on Discord, ignore any of this, but please add TODOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.