Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React >= 14.x.x #19

Open
bompi88 opened this issue Aug 23, 2016 · 3 comments
Open

Support React >= 14.x.x #19

bompi88 opened this issue Aug 23, 2016 · 3 comments

Comments

@bompi88
Copy link

bompi88 commented Aug 23, 2016 •
edited
Loading

Hi,

great package ! Love to see React >= 14.x.x support though. this.getDOMNode is now ReactDOM.findDOMNode(this) I think. I could create a PR if you want, but you should review it before merging.
@kaleposhobios
Copy link

+1

@quantizor
Copy link
Contributor

Hey folks - we actually deprecated the module as we don't have the bandwidth to continue supporting it at present. If someone wants to send a PR though, will happily review.

bompi88 added a commit to bompi88/react-input-placeholder that referenced this issue Aug 23, 2016
@bompi88
First try on React >= 14.0.0 support. fixes enigma-io#19
439e51b
@bompi88
Copy link
Author

bompi88 commented Aug 23, 2016 •
edited
Loading

@yaycmyk thanks. I did a try at fixing this here: #20. I'm not familiar with amd and how modules are declared, so I just assumed something and did that ;)

@bompi88 bompi88 changed the title Support React 15.x.x Support React 14.x.x Aug 23, 2016
@bompi88 bompi88 changed the title Support React 14.x.x Support React >= 14.x.x Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quantizor @bompi88 @kaleposhobios