feat: add tokenId to marketplace pallet events broadcasted over SNS #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawell67
requested review from
leonardocustodio and
justraman
as code owners
pawell67
force-pushed
the
add-token-id-to-marketplace-events-sns
branch
2 times, most recently
from
a106219
to
7e2fbca
Compare
pawell67
force-pushed
the
add-token-id-to-marketplace-events-sns
branch
from
7e2fbca
to
39907c9
Compare
justraman
reviewed
Sep 21, 2024
justraman
reviewed
Sep 21, 2024
justraman
reviewed
Sep 21, 2024
leonardocustodio
previously approved these changes
Sep 23, 2024
justraman
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nftio, when processing marketplace events (listings) there is a need of cache invalidation based on incoming event. However there is only listingId supplied in the event and it adds requirement of additional call to indexer to know what token is listing related to. By adding tokenId all required information will come in the event