Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pusher #519

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Remove pusher #519

merged 1 commit into from
Jul 31, 2023

Conversation

leonardocustodio
Copy link
Member

No description provided.

@leonardocustodio leonardocustodio added the enhancement New feature or request label Jul 23, 2023
@leonardocustodio leonardocustodio self-assigned this Jul 23, 2023
justraman
justraman approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@justraman justraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason to remove it, isn't NFT.io already using Pusher?

@leonardocustodio
Copy link
Member Author

Talles said you guys were not going to use it anymore, can you confirm with him?

@tallesborges
Copy link

Hey @justraman, I initially had a plan to use it but ended up changing my mind. Currently, on nftio, we are only using Pusher for platform events.

@leonardocustodio leonardocustodio merged commit 4ac983d into master Jul 31, 2023
5 checks passed
@leonardocustodio leonardocustodio deleted the remove-pusher branch July 31, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallesborges tallesborges tallesborges approved these changes

@justraman justraman justraman approved these changes

Assignees

@leonardocustodio leonardocustodio

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardocustodio @tallesborges @justraman