Fix issues

enjin · Oct 4, 2024 · 4b58444 · 4b58444
1 parent 713ab90
commit 4b58444
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Commands/SyncAttributeMetadata.php b/src/Commands/SyncAttributeMetadata.php
@@ -40,8 +40,11 @@ public function handle(MetadataService $service): void
         $query->chunk(
             config('enjin-platform.sync_metadata.data_chunk_size'),
             function ($attributes) use ($progress, $service): void {
-                $attributes->each(fn (Attribute $attribute) => $service->fetchAndCache($attribute));
-                $progress->advance($attributes->count());
+                $attributes->each(function (Attribute $attribute) use ($progress, $service): void {
+                    $service->fetchAndCache($attribute);
+                    $progress->advance(1);
+                });
+
             }
         );
         $progress->finish();

diff --git a/src/Services/Database/MetadataService.php b/src/Services/Database/MetadataService.php
@@ -41,8 +41,12 @@ public function fetchAndCache(?Attribute $attribute): mixed
         );
     }
 
-    public function getCache(Attribute $attribute): mixed
+    public function getCache(?Attribute $attribute): mixed
     {
+        if (!filter_var($attribute?->value, FILTER_VALIDATE_URL)) {
+            return null;
+        }
+
         return Cache::get($this->cacheKey($attribute->value), $this->fetchAndCache($attribute));
     }