Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-2033] Add AuctionData back #264

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[PLA-2033] Add AuctionData back #264

merged 1 commit into from
Oct 11, 2024

Conversation

leonardocustodio
Copy link
Member

@leonardocustodio leonardocustodio commented Oct 11, 2024

PR Type

enhancement


Description

  • Added a new AuctionData type to the ListingStorage.json file, which includes startBlock and endBlock fields.
  • Enhanced the ListingData enum to incorporate the newly added AuctionData type.

Changes walkthrough 📝

Relevant files
Enhancement
ListingStorage.json
Add `AuctionData` type and enhance `ListingData` enum       

src/Services/Processor/Substrate/Codec/Types/ListingStorage.json

  • Added AuctionData type with startBlock and endBlock fields.
  • Enhanced the ListingData enum to include AuctionData.
  • +4/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Signed-off-by: Leonardo Custodio <[email protected]>
    @leonardocustodio leonardocustodio changed the title Update ListingStorage.json [PLA-2033] Add AuctionData back Oct 11, 2024
    @leonardocustodio leonardocustodio self-assigned this Oct 11, 2024
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Ensure consistency in data types used for block numbers across the system

    Ensure that the "Compact" type used for "startBlock" and "endBlock" in "AuctionData"
    is consistent with the rest of the system's handling of block numbers. If the system
    uses a different type for block numbers elsewhere, consider aligning them to prevent
    type mismatches.

    src/Services/Processor/Substrate/Codec/Types/ListingStorage.json [28-30]

     "AuctionData": {
    -  "startBlock": "Compact<u32>",
    -  "endBlock": "Compact<u32>"
    +  "startBlock": "AlignedType",
    +  "endBlock": "AlignedType"
     }
    Suggestion importance[1-10]: 7

    Why: The suggestion highlights a potential inconsistency in data types for block numbers, which could lead to type mismatches. Ensuring consistency across the system is important for maintainability and correctness, but the suggestion is not directly actionable as it requires verification of existing system types.

    7

    @leonardocustodio leonardocustodio merged commit ab463d6 into master Oct 11, 2024
    6 of 7 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Development

    Successfully merging this pull request may close these issues.

    2 participants