[PLA-1426] Fixes issues with unserved&reserved

[leonardocustodio]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: This PR seems to be focused on fixing issues related to token reservation and unreservation in a blockchain application.
• 📝 PR summary: The PR introduces changes in three files, mainly replacing 'Reserved' with 'Unreserved' in the first file, adding a check for null before incrementing the amount in the second file, and adding a new import in the third file.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and don't involve complex logic or architecture changes.
• 🔒 Security concerns: No

PR Feedback

• 💡 General suggestions: The changes in the PR seem to be addressing a specific issue with token reservation and unreservation. However, it would be beneficial to include a more detailed description or comments in the code to explain the changes and their impact on the overall functionality.

• 🤖 Code feedback:

  • relevant file: src/Services/Processor/Substrate/Events/Implementations/MultiTokens/Reserved.php
    suggestion: Consider using the null coalescing operator to simplify the if-else structure when checking for null and incrementing the amount. [medium]
    relevant line: if ($namedReserve == null) {

  • relevant file: src/Services/Processor/Substrate/Codec/Polkadart/Events/MultiTokens/Unreserved.php
    suggestion: Ensure that changing from 'Reserved' to 'Unreserved' does not introduce any unexpected behavior or bugs in the application. [important]
    relevant line: $self->collectionId = Arr::get($data, 'event.MultiTokens.Unreserved.collection_id');

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.