This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Prepare 3.0.1 #186
Merged
Prepare 3.0.1 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyelidlessness
force-pushed
the
prerelease/3.0.1
branch
from
67750ae
to
fe1477c
Compare
- No vulnerabilities reported by `npm audit` in project or demo. - Pretty sure I addressed everything reported by Dependabot. It would be nice if there was a way to validate this before merging? - Other dependencies updated - Fixed: removed `@ts-expect-error` in src/dom/node/Node.ts, as TypeScript now supports different getter/setter types. - Added note about `threads`/`singleThread` config API change for future Vitest updates
eyelidlessness
force-pushed
the
prerelease/3.0.1
branch
from
fe1477c
to
8f2f80b
Compare
eyelidlessness
commented
Aug 18, 2023
| // also caused problems with changes to the | ||
| // snapshot format. | ||
| // singleThread: true, | ||
|
|
There was a problem hiding this comment.
This isn't really related. But it took a fair bit of time to figure out, and I'd hate to repeat that if/when we update Vitest again in the future.
lognaturel
approved these changes
Aug 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm auditin project or demo.@ts-expect-errorin src/dom/node/Node.ts, as TypeScript now supports different getter/setter types.threads/singleThreadconfig API change for future Vitest updatesNote: Vitest was not updated past 0.28.5, because newer versions would update the snapshot format.