-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XmlObjectParser skips validation for sources without namespaces #9573 #10010
base: master
Are you sure you want to change the base?
Conversation
c768f32
to
395ca20
Compare
395ca20
to
cb564a2
Compare
Codecov ReportBase: 83.99% // Head: 84.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10010 +/- ##
=========================================
Coverage 83.99% 84.00%
- Complexity 19290 19296 +6
=========================================
Files 2580 2580
Lines 67749 67769 +20
Branches 5464 5468 +4
=========================================
+ Hits 56905 56927 +22
+ Misses 8137 8134 -3
- Partials 2707 2708 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
private String systemId; | ||
|
||
private CharSource source; | ||
|
||
public XmlObjectParser( final String namespace ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add default ctor that, if used, does not force any namespace. namespace = null
source.setSystemId( this.systemId ); | ||
|
||
final DOMResult result = VALIDATOR.validate( source ); | ||
return (Document) result.getNode(); | ||
} | ||
|
||
private Document processDocument( final Document doc ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better call it forceNamespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to cancel this change
- apps may suddenly stop working due to extra validation
- we may want to focus on json schema for descriptors
No description provided.