use json schema and validation for configuration

[DanielHabenicht]

Here is my draft for using a schema instead of Markdown to document the ctf.json.

It also validates part of the JSON with the Schema (only those parts supported by the JSONschema).

I also fixed the files checked in for .net (e.g. launchSettings.json which should be shared for an easier setup).

[Savallator]

Can you please not mix up several different issues in one pull request?
Also, the changes for the gitignore are not helpful at all.

[DanielHabenicht]

Can you please not mix up several different issues in one pull request?

yes, sorry will update it.

Also, the changes for the gitignore are not helpful at all.

They are:

1. launchSettings.json should be shared so that ports etc. are standardized for all developers
2. Instead of adding every file by hand using the standard predefined .gitignore from Microsoft will ensure that nothing gets included/excluded that shouldn't be instead of googling every new file type. (e.g. the previous setting of excluding the whole Properties folder and cproj.user files not being excluded currently).

[Savallator]

We did use a standard predefined .gitignore. Also e.g. removing the ctf.*.json there is not helpful. Maybe you should get some experience with actually using the software first so you know some of the basic usecases?

[Savallator]

Also, could you please not remove the whitespaces we put into the readme for readability?

[DanielHabenicht]

We did use a standard predefined .gitignore. Also e.g. removing the ctf.*.json there is not helpful. Maybe you should get some experience with actually using the software first so you know some of the basic usecases?

I agree with that. But also you have ctf.bambi3.json and more checked into the repository, so it is kind of contradictory.

Also, could you please not remove the whitespaces we put into the readme for readability?

Yes, that was my autoformatter.

[Savallator]

I agree with that. But also you have ctf.bambi3.json and more checked into the repository, so it is kind of contradictory.

Those were checked in deliberately by hand. But you don't want to get every test file in there.

[DanielHabenicht]

Those were checked in deliberately by hand. But you don't want to get every test file in there.

Then maybe move these files into an /archive folder? and exclude it from git.

[Trolldemorted]

Then maybe move these files into an /archive folder? and exclude it from git.

Then we would lose track of which services were played when, which is bad for servicerecyclingcoin, but we are currently considering moving them into a dedicated repository together with dumps of their databases.

[DanielHabenicht]

updated as you requested.

[DanielHabenicht]

I don't know who was sad about using Newtonsoft again, but I found a package which extends the built in JSON Serializer. (https://gregsdennis.github.io/json-everything/usage/schema-generation.html)

If someone wants to comment on whether you actually want to document it as JSON Schema I can remodel it to use the other package.

[domenukk]

Is this schema autogenerated? Else we could do more useful maxima than "21x age of the universe" seconds :D
Obviously not a big deal for now, just wondering :)

[DanielHabenicht]

Yes it's auto-generated. I made the core package executable for that purpose.

[DanielHabenicht]

But you can put in any number you want in the .cs file describing the entity.

[Trolldemorted]

Why does github display this as a diff? Did the linefeeds change?

[DanielHabenicht]

Seems like Visual Studio loves CRLF

[DanielHabenicht]

but for me it shows up as LF..

[Savallator]

i think it might be possible to enforce one kind of line endings project-wide, at least i read about that somewhere

[Savallator]

Otherwise it will depend on the settings of the one editing it, which is bad imho.

[DanielHabenicht]

but with .gitattributes I didn't see any changes

[Trolldemorted]

There is e.g. .editorconfig, but with VS it was a clusterfuck a few years back - if you specify \n linefeeds then new classes will have \r\n boilerplate code, and any linefeeds you enter will be \n only

[DanielHabenicht]

as I worked with the other projects I would say that the file probably was CRLF and now is LF only.

[DanielHabenicht]

we can run a formater like https://restyled.io/ on all project if you like. I can set it up but you need to allow the application.

[ldruschk]

not sure what the current state on the discussion of LF vs CR+LF is, but apart from that looks good

[DanielHabenicht]

not sure what the current state on the discussion of LF vs CR+LF is, but apart from that looks good

As far as I know the file was checked in as CRLF (current master) an is now LF (my PR).
(Other files might still be checked in as CRLF so I think it might be a good idea to incorporate https://restyled.io/ I can set it up if you'd like, but you will have to install it to the Org.