Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post.html #118

Merged
merged 2 commits into from
May 27, 2021
Merged

Update post.html #118

merged 2 commits into from
May 27, 2021

Conversation

DanielHabenicht
Copy link
Contributor

@DanielHabenicht DanielHabenicht commented May 25, 2021

use a default flag with the length it will have during the contest (as some implementations might be dependent on the length of the flag

use flag with the length it will have during the contest (as some implementations might be dependent on the length of the flag
@domenukk
Copy link
Member

domenukk commented May 25, 2021

I don't think we ever specified a specific flag length, imho services should not depend on the current implementation. Is there a service that actually needs a fixed length?
/edit: don't discuss here / leak internals :)

@DanielHabenicht
Copy link
Contributor Author

DanielHabenicht commented May 25, 2021

At least the checker is defining a fixed length:

https://github.com/enowars/enochecker_test/blob/a52c0e8c9319ecdbfbcbb53a610ea193a30d0738/enochecker_test/tests.py#L17

Apart from the discussion, I think it would be good to test with an actual "Flag" (size and character-wise, I can add some more of them as defined in the regex if you like)

My service is dependent on the length of the flag, but I think that is okay for the upcoming CTF. But in general, I agree.

@ldruschk
Copy link
Member

I don't think we ever specified a specific flag length, imho services should not depend on the current implementation. Is there a service that actually needs a fixed length?
/edit: don't discuss here / leak internals :)

We did not really specify it, but in that case we should test different flag formats/lengths with enochecker_test. It does make sense to have reasonable default values that match what will likely be used during the actual CTF.

@ldruschk ldruschk merged commit c769b67 into enowars:main May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants