Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny DB Access for Exploits #129

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Deny DB Access for Exploits #129

merged 3 commits into from
Jun 21, 2021

Conversation

domenukk
Copy link
Member

@domenukk domenukk commented Jun 21, 2021

This PR denies DB access for the exploit method.
In general, this is fine, the only issue I see is that, right now, we don't expose any way to use attackinfo in exploits. Maybe users need the db to emulate attackinfo for now?

@domenukk domenukk requested a review from ldruschk June 21, 2021 13:43
@ldruschk
Copy link
Member

We actually do have the attack_info available in the exploit-Method and this is also set by enochecker_test. Although that might be missing from the web intreface atm

@ldruschk ldruschk merged commit 3798117 into main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants