Re-Enable Speech Recognition on Safari (still untested on iPhones)

enricoros · Sep 19, 2023 · 34d5a32 · 34d5a32 · vercel · Sep 19, 2023
1 parent 7f49ddb
commit 34d5a32
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/common/components/useSpeechRecognition.ts b/src/common/components/useSpeechRecognition.ts
@@ -1,6 +1,6 @@
 import * as React from 'react';
 
-import { isChromeOnDesktopWindows, isSafariOriPhone } from '~/common/util/pwaUtils';
+import { isChromeOnDesktopWindows, isIPhone } from '~/common/util/pwaUtils';
 import { useUIPreferencesStore } from '~/common/state/store-ui';
 
 
@@ -12,7 +12,7 @@ export interface SpeechResult {
 
 
 export function maySpeechRecognitionWork() {
-  return !isSafariOriPhone() && !!getSpeechRecognition();
+  return !isIPhone() && !!getSpeechRecognition();
 }
 
 /**
@@ -47,8 +47,8 @@ export const useSpeechRecognition = (onResultCallback: (result: SpeechResult) =>
     }
 
     // skip speech recognition on iPhones and Safari browsers - because of sub-par quality
-    if (isSafariOriPhone()) {
-      console.log('Speech recognition is disabled on iPhones and Safari browsers.');
+    if (isIPhone()) {
+      console.log('Speech recognition is disabled (not yet tested) on iPhones.');
       return;
     }
 

diff --git a/src/common/util/pwaUtils.ts b/src/common/util/pwaUtils.ts
@@ -20,10 +20,11 @@ export function isPwa(): boolean {
 //   return true;
 // };
 
-export function isSafariOriPhone(): boolean {
-  const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
+export function isIPhone(): boolean {
+  // const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
+  // noinspection UnnecessaryLocalVariableJS
   const isiPhone = /iPhone|iPod/.test(navigator.userAgent);
-  return isSafari || isiPhone;
+  return /*isSafari ||*/ isiPhone;
 }
 
 export const isChromeOnDesktopWindows = (): boolean => {