Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FET-1619 If tab specified in query string doesn't exist, app crashes. Should redirect to profile tab #835

Merged
merged 19 commits into from
Sep 13, 2024
Merged

FET-1619 If tab specified in query string doesn't exist, app crashes. Should redirect to profile tab #835

merged 19 commits into from
Sep 13, 2024

Conversation

vuongnmdevblock
Copy link
Collaborator

No description provided.

@vuongnmdevblock vuongnmdevblock added the bug Something isn't working label Aug 28, 2024
@vuongnmdevblock vuongnmdevblock self-assigned this Aug 28, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 29, 2024 •
edited
Loading

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: cd45645
Status: ✅  Deploy successful!
Preview URL: https://45e2b461.ens-app-v3.pages.dev
Branch Preview URL: https://fix-fet-1619.ens-app-v3.pages.dev

View logs

storywithoutend
storywithoutend requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@storywithoutend storywithoutend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add tests to shouldRedirect.test.ts

src/components/pages/profile/[name]/Profile.tsx Show resolved Hide resolved
src/utils/shouldRedirect.ts Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sugh01 sugh01 merged commit b2157df into main Sep 13, 2024
39 checks passed
@sugh01 sugh01 deleted the fix/FET-1619 branch September 13, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storywithoutend storywithoutend storywithoutend approved these changes

@sugh01 sugh01 sugh01 approved these changes

@LeonmanRolls LeonmanRolls Awaiting requested review from LeonmanRolls

@nhohb nhohb Awaiting requested review from nhohb

Assignees

@vuongnmdevblock vuongnmdevblock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vuongnmdevblock @storywithoutend @sugh01 @nhohb