Add more descriptive texts to registration transaction screen #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (40 commits) Update bitcoin block explorer matching copy definition from FET-1571 fix unit test for block explorer= minor updates remove unneccessary isEthAddress -> updateRecordAtIndex calls code clean up and added some additional tests added more tests to profileRecordUtils.test remove console.log rearrange variable rewrote coin mapper to output dictionary for coins by coin name and modified associating functions update profileRecordUtils update profileRecordUtils updating comment to be more accurate Updating conditional logic to be a little more reliable update getProfileRecordsDiff Change owner and manager user to makes it easier to read the makeName if we can assume user is the test user. minor fixes updated address profile button code to pull from local files instead of through the coin worker Add E2E test case for edit profile button: "Should show disabled edit profile button if name is wrapped but use for edit resolver is burned and resolver is unauthorised" Revert dependencies for useProfileActions to avoid unexpected rerender, update manager user to user2 for test case "Should show edit profile button if user is manager" ...
* main: Remove comments FET-1547: Redirect after subname creation to profile for that subname
Deploying ens-app-v3 with
|
| Latest commit: |
98b689c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f118e5b.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fet-1264-registration-info.ens-app-v3.pages.dev |
sugh01
approved these changes
Sep 12, 2024
sugh01
requested changes
Sep 12, 2024
|
sugh01
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes merge of "more accurate duration text PR"