Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove a bunch of unused deps #879

Merged
merged 2 commits into from
Sep 20, 2024
Merged

remove a bunch of unused deps #879

merged 2 commits into from
Sep 20, 2024

Conversation

talentlessguy
Copy link
Collaborator

also

  • use node 20 instead of 18 for knip like all other GHAs
  • replace glob with tinyglobby

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: e74f31a
Status: ✅  Deploy successful!
Preview URL: https://5a829527.ens-app-v3.pages.dev
Branch Preview URL: https://remove-all-unused-deps.ens-app-v3.pages.dev

View logs

@talentlessguy talentlessguy merged commit 3c58874 into main Sep 20, 2024
40 checks passed
@talentlessguy talentlessguy deleted the remove-all-unused-deps branch September 20, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugh01 sugh01 sugh01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talentlessguy @sugh01