Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification of application configuration between JS and Rust codebases. #5664

Closed
wdanilo opened this issue Feb 15, 2023 · 1 comment
Closed
Assignees
Labels
d-intermediate Difficulty: some prior knowledge required x-chore Type: chore
Milestone

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 15, 2023

Describe the idea you'd like to see implemented.

This issue should be implemented as a PR to this branch: https://github.com/enso-org/enso/tree/wip/wdanilo/shader-compilation-improvement-184304289

It will be later moved to develop when this branch will be closed.

Right now, we have the same configuration description in multiple places, in particular:

  • lib/rust/ensogl/pack/src/runner/config.ts contains the same data as lib/rust/ensogl/pack/src/runner/config.json
  • app/ide-desktop/lib/content-config/index.ts contains the same data as app/ide-desktop/lib/content-config/config.json

We have them in both places because both TypeScript and Rust code uses them. Rust loads the config.json files, TypeScript should as well.

The goal of this task is to remove the hardcoded config from TypeScript files. They should load the config from these config.json files by importing them (something like import * from 'config.json'). The data structures in TypeScript files (Option, Group, etc) should be preserved in order to keep all the files type-safe - the loaded JSON files should be converted to the Group / Option tree.

Is your feature request related to a problem?

No response

Screenshots, screencasts, mockups.

No response

Would you be willing to help us implement this feature?

No

@wdanilo wdanilo added d-intermediate Difficulty: some prior knowledge required x-chore Type: chore -gui labels Feb 15, 2023
@sylwiabr sylwiabr added this to the Beta Release milestone Feb 16, 2023
@enso-org enso-org deleted a comment from enso-bot bot Feb 16, 2023
@enso-org enso-org deleted a comment from enso-bot bot Feb 16, 2023
@enso-bot enso-bot bot mentioned this issue Feb 16, 2023
wdanilo added a commit that referenced this issue Feb 18, 2023
@wdanilo
Copy link
Member Author

wdanilo commented Feb 19, 2023

I already implemented it :)

@wdanilo wdanilo closed this as completed Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-intermediate Difficulty: some prior knowledge required x-chore Type: chore
Projects
Archived in project
Development

No branches or pull requests

3 participants