You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It will be later moved to develop when this branch will be closed.
Right now, we have the same configuration description in multiple places, in particular:
lib/rust/ensogl/pack/src/runner/config.ts contains the same data as lib/rust/ensogl/pack/src/runner/config.json
app/ide-desktop/lib/content-config/index.ts contains the same data as app/ide-desktop/lib/content-config/config.json
We have them in both places because both TypeScript and Rust code uses them. Rust loads the config.json files, TypeScript should as well.
The goal of this task is to remove the hardcoded config from TypeScript files. They should load the config from these config.json files by importing them (something like import * from 'config.json'). The data structures in TypeScript files (Option, Group, etc) should be preserved in order to keep all the files type-safe - the loaded JSON files should be converted to the Group / Option tree.
Is your feature request related to a problem?
No response
Screenshots, screencasts, mockups.
No response
Would you be willing to help us implement this feature?
No
The text was updated successfully, but these errors were encountered:
Describe the idea you'd like to see implemented.
This issue should be implemented as a PR to this branch: https://github.com/enso-org/enso/tree/wip/wdanilo/shader-compilation-improvement-184304289
It will be later moved to develop when this branch will be closed.
Right now, we have the same configuration description in multiple places, in particular:
lib/rust/ensogl/pack/src/runner/config.ts
contains the same data aslib/rust/ensogl/pack/src/runner/config.json
app/ide-desktop/lib/content-config/index.ts
contains the same data asapp/ide-desktop/lib/content-config/config.json
We have them in both places because both TypeScript and Rust code uses them. Rust loads the
config.json
files, TypeScript should as well.The goal of this task is to remove the hardcoded config from TypeScript files. They should load the config from these
config.json
files by importing them (something likeimport * from 'config.json'
). The data structures in TypeScript files (Option
,Group
, etc) should be preserved in order to keep all the files type-safe - the loaded JSON files should be converted to theGroup
/Option
tree.Is your feature request related to a problem?
No response
Screenshots, screencasts, mockups.
No response
Would you be willing to help us implement this feature?
No
The text was updated successfully, but these errors were encountered: