Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS Code Signing & Notarization #3712

Merged
merged 19 commits into from
Sep 19, 2022
Merged

macOS Code Signing & Notarization #3712

merged 19 commits into from
Sep 19, 2022

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Sep 15, 2022 •
edited
Loading

Pull Request Description

This PR reenables code signing and notarization on macOS.

[ci no changelog needed]

Important Notes

  • electron-builder has been bumped, mostly to avoid missing Python issue. A workaround for a regression with Windows installer is provided as a patch.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@mwu-tow mwu-tow changed the title [WIP] macOS Code Signing & Notarization macOS Code Signing & Notarization Sep 19, 2022
@mwu-tow mwu-tow marked this pull request as ready for review September 19, 2022 09:49
@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label Sep 19, 2022
@mergify mergify bot merged commit 10f45d7 into develop Sep 19, 2022
@mergify mergify bot deleted the wip/mwu/macos-signing branch September 19, 2022 19:02
@mwu-tow mwu-tow mentioned this pull request Sep 20, 2022
Merged
4 tasks
mwu-tow added a commit that referenced this pull request Sep 21, 2022
@mwu-tow
Fixing yargs and electron-builder regressions (#3725)
d6bd800 
This PR reverts two version bumps from #3712:
* `yargs` needs to be downgraded, because a never version can trigger evanw/esbuild#2441
* `electron-builder` needs to be downgraded, because our workaround for electron-userland/electron-builder#6865 proved insufficient.

As the upstream issues are resolved, we should bump these dependencies again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelMauderer MichaelMauderer MichaelMauderer approved these changes

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwu-tow @MichaelMauderer