This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Do not crash the IDE when logging non-string objects. #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
added
Good First Issue
MichaelMauderer
force-pushed
the
wip/mm/fix-log-crashing
branch
from
9a566b4
to
db9feb5
Compare
wdanilo
approved these changes
Mar 11, 2021
MichaelMauderer
force-pushed
the
wip/mm/fix-log-crashing
branch
from
bff7b9f
to
722fb98
Compare
[ci no changelog needed]
MichaelMauderer
force-pushed
the
wip/mm/fix-log-crashing
branch
from
da32fc0
to
4aab6af
Compare
|
@wdanilo Can you merge this? It does not require a changelog entry, but the CI won't let it pass. |
|
@MichaelMauderer I would add a changelog entry for it! Like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes a bug in the log handler that crashes the IDE when it encounters a non-string object.
Checklist
Please include the following checklist in your PR:
TheCHANGELOG.mdwas updated with the changes introduced in this PR.The documentation has been updated if necessary.All code has automatic tests where possible.All code has been profiled where possible.