This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
Difficulty: Core Contributor
Should only be attempted by a core contributor
Priority: High
Should be scheduled as soon as possible
Type: Enhancement
An enhancement to the current state of Enso IDE
Category: GUI
The Graphical User Interface
labels
Jul 1, 2021
wdanilo
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be releasing that to a big audience next week. Please triple check that with Marcin (he is sick but if you write to him to double check it, e'd probably do it) if the emails are correctly logged to mixpanel.
Comment on lines
+474
to
+483
/// Set custom user agent to fix the issue with Google authentication. | ||
/// | ||
/// Google authentication doesn't work with the default Electron user agent. And | ||
/// Google is quite picky about the values you provide. For example, just | ||
/// removing Electron occurrences from the default user agent doesn't work. This | ||
/// user agent was chosen by trial and error as a stable one. | ||
/// | ||
/// https://github.com/firebase/firebase-js-sdk/issues/2478 | ||
function setUserAgent() { | ||
const agent = 'Mozilla/5.0 (Windows NT 10.0; WOW64; rv:70.0) Gecko/20100101 Firefox/70.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so strange. It's ok, just strange
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Add authentication and minimum supported version check Original commit: enso-org/ide@2e2a804
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Category: GUI
The Graphical User Interface
Difficulty: Core Contributor
Should only be attempted by a core contributor
Priority: High
Should be scheduled as soon as possible
Type: Enhancement
An enhancement to the current state of Enso IDE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1635
Add authentication and minimum supported version check.
Changelog:
config.json
on thedevelopment
branch.package.json
of theclient
js module (/src/js/lib/package.json
)Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.md
was updated with the changes introduced in this PR.