Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Modify list view api to support custom entry #1722

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Modify list view api to support custom entry #1722

merged 4 commits into from
Jul 22, 2021

Conversation

farmaazon
Copy link
Collaborator

@farmaazon farmaazon commented Jul 22, 2021 •
edited
Loading

[ci no changelog needed]

Pull Request Description

This is a prerequisite of merging #1700 PR which uses a list_view API. The new API was introduced to allow usage of list views in file browser and new searcher components.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@farmaazon farmaazon added Difficulty: Hard Significant prior knowledge requried Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE Category: GUI The Graphical User Interface labels Jul 22, 2021
@farmaazon farmaazon self-assigned this Jul 22, 2021
@farmaazon farmaazon marked this pull request as ready for review July 22, 2021 11:44
@farmaazon farmaazon requested a review from wdanilo as a code owner July 22, 2021 11:44
wdanilo
wdanilo approved these changes Jul 22, 2021
View reviewed changes
src/rust/ensogl/example/src/list_view.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/list_view/entry.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/list_view/entry.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/list_view/entry.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/list_view/entry/list.rs Outdated Show resolved Hide resolved
src/rust/ensogl/lib/components/src/list_view/entry/list.rs Outdated Show resolved Hide resolved
@farmaazon farmaazon merged commit b398ad9 into develop Jul 22, 2021
@farmaazon farmaazon deleted the wip/ao/new-list-view-api branch July 22, 2021 17:37
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@farmaazon
Modify list view api to support custom entry (enso-org/ide#1722)
cd07d94 
Also fixed issue with not-masked selected entry in visualization chooser.

Original commit: enso-org/ide@b398ad9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wdanilo wdanilo wdanilo approved these changes

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

Assignees

@farmaazon farmaazon

Labels
Category: GUI The Graphical User Interface Difficulty: Hard Significant prior knowledge requried Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farmaazon @wdanilo