Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

GeoMap: Ignore points with null coordinate values #1775

Merged
merged 5 commits into from
Aug 19, 2021

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Aug 10, 2021

Pull Request Description

Presence of such entries cause issues with geomap initial centering.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
    - [ ] All code has automatic tests where possible.
    - [ ] All code has been profiled where possible.
  • All code has been manually tested in the IDE.
    - [ ] All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow requested a review from wdanilo as a code owner August 10, 2021 11:54
@mwu-tow mwu-tow self-assigned this Aug 10, 2021
@mwu-tow mwu-tow added the Category: Visualizations Visualizations embedded in Enso IDE label Aug 10, 2021
@wdanilo
Copy link
Member

wdanilo commented Aug 17, 2021

Why is this not merged? It was approved 5 days ago

@farmaazon
Copy link
Collaborator

Why is this not merged? It was approved 5 days ago

Not all items in checklist are checked.

@MichaelMauderer MichaelMauderer merged commit 525b340 into develop Aug 19, 2021
@MichaelMauderer MichaelMauderer deleted the wip/mwu/geomap-null-points branch August 19, 2021 15:05
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Visualizations Visualizations embedded in Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants