This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Fix parsing of boolean command line options #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s9ferech
added
Priority: High
MichaelMauderer
suggested changes
Aug 26, 2021
CHANGELOG.md
Outdated
|
|
||
| #### Visual Environment | ||
|
|
||
| - [Correct handling of command-line flags.][1815] Command line arguments of the |
There was a problem hiding this comment.
This should be in the "Next Release" section.
MichaelMauderer
approved these changes
Aug 27, 2021
# Conflicts: # CHANGELOG.md # src/js/lib/client/src/index.js
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Instruct our argument parser to parse boolean options as booleans. Previously, when given command line arguments like
--option=falseor--option false, we would assign the string'false'tooption. Now we correctly assign the booleanfalse. This fixes issue #1813.Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.