Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Feature flag for visualization preview #1817

Merged
merged 5 commits into from
Aug 31, 2021
Merged

Feature flag for visualization preview #1817

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77a3f7b
Feature flag for visualization preview
s9ferech Aug 25, 2021
0a91eed
Update CHANGELOG.md
s9ferech Aug 25, 2021
c10ee40
Requested changes
s9ferech Aug 26, 2021
b114a4c
Remove duplication from CHANGELOG
s9ferech Aug 26, 2021
5fb9db4
Merge branch 'develop' into wip/fr/vis-preview-flag
MichaelMauderer Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@

<br/>![New Features](/docs/assets/tags/new_features.svg)

#### Enso Compiler
#### Visual Environment

- [Improvements to visualization handling][1804]. These improvements are fixing
possible performance issues around attaching and detaching visualizations.
- [GeoMap visualization will ignore points with `null` coordinates][1775]. Now
the presence of such points in the dataset will not break initial map
positioning.
- [Visualization previews are disabled.][1817] Previously, hovering over a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the "Next Release" section.

node's output port for more than four seconds would temporarily reveal the
node's visualization. This behavior is disabled now.

#### Enso Compiler

Expand All @@ -22,6 +25,7 @@
[1775]: https://github.com/enso-org/ide/pull/1775
[1798]: https://github.com/enso-org/ide/pull/1798
[1804]: https://github.com/enso-org/ide/pull/1804
[1817]: https://github.com/enso-org/ide/pull/1817

# Enso 2.0.0-alpha.11 (2021-08-09)

Expand Down
11 changes: 7 additions & 4 deletions src/rust/ide/view/graph-editor/src/component/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,11 @@ pub const COMMENT_MARGIN : f32 = 10.0;
const INFINITE : f32 = 99999.0;
const ERROR_VISUALIZATION_SIZE : (f32,f32) = visualization::container::DEFAULT_SIZE;

const VISUALIZATION_OFFSET_Y : f32 = -120.0;
const VISUALIZATION_OFFSET_Y : f32 = -120.0;

const VIS_PREVIEW_ONSET_MS : f32 = 4000.0;
const ERROR_PREVIEW_ONSET_MS : f32 = 0000.0;
const ENABLE_VIS_PREVIEW : bool = false;
const VIS_PREVIEW_ONSET_MS : f32 = 4000.0;
const ERROR_PREVIEW_ONSET_MS : f32 = 0000.0;
/// A type of unresolved methods. We filter them out, because we don't want to treat them as types
/// for ports and edges coloring (due to bad UX otherwise).
const UNRESOLVED_SYMBOL_TYPE : &str = "Builtins.Main.Unresolved_Symbol";
Expand Down Expand Up @@ -745,7 +746,9 @@ impl Node {
preview_visible <- preview_visible && has_expression;
preview_visible <- preview_visible.on_change();

visualization_visible <- visualization_enabled || preview_visible;
visualization_visible <- all_with(&visualization_enabled,&preview_visible,
|&visualization_enabled,&preview_visible|
visualization_enabled || (preview_visible && ENABLE_VIS_PREVIEW));
visualization_visible <- visualization_visible && no_error_set;
visualization_visible_on_change <- visualization_visible.on_change();
frp.source.visualization_visible <+ visualization_visible_on_change;
Expand Down