This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Delayed Visualization Attaching #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
approved these changes
Aug 31, 2021
Comment on lines
+115
to
+126
| pub fn handle_notification | ||
| (&self, notification: Notification) -> FallibleResult { | ||
| match notification { | ||
| Notification::Completed => { | ||
| if !self.model.is_ready.replace(true) { | ||
| WARNING!("Context {self.id} Became ready"); | ||
| } | ||
| } | ||
| Notification::ExpressionUpdates(updates) => { | ||
| self.model.computed_value_info_registry.apply_updates(updates); | ||
| } | ||
| } |
There was a problem hiding this comment.
If it is the ExecutionContext which both defines and handles the notification, why we cannot just create functions "handle_expression_updates" and "mark_as_ready"?
Co-authored-by: Adam Obuchowicz <[email protected]>
MichaelMauderer
approved these changes
Sep 8, 2021
…layed-visualization-attaching
mwu-tow
added a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR:
Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.