Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Refactoring IDE models. #681

Merged
merged 32 commits into from
Jul 21, 2020
Merged

Refactoring IDE models. #681

merged 32 commits into from
Jul 21, 2020

Conversation

farmaazon
Copy link
Collaborator

Pull Request Description

The goal is to mark clear responsibility of models and controllers in ide crate. Also, to make tests simpler, for each model the API trait was added.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Rust.
  • All code has been tested where possible.
  • All code has been profiled where possible.

farmaazon and others added 26 commits July 9, 2020 11:12
@farmaazon farmaazon added Change: Non-Breaking Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE labels Jul 21, 2020
@farmaazon farmaazon added the Category: Controllers The Application layer not bound to visual part label Jul 21, 2020
@farmaazon farmaazon requested a review from mwu-tow July 21, 2020 10:52
@farmaazon farmaazon requested a review from wdanilo as a code owner July 21, 2020 10:52
@farmaazon farmaazon self-assigned this Jul 21, 2020
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

farmaazon
farmaazon commented Jul 21, 2020
View reviewed changes
src/rust/ide/lib/parser/src/wsclient.rs Outdated Show resolved Hide resolved
src/rust/ide/lib/parser/src/wsclient.rs Outdated Show resolved Hide resolved
src/rust/ide/src/controller/graph.rs Show resolved Hide resolved
src/rust/ide/src/controller/graph.rs Outdated Show resolved Hide resolved
src/rust/ide/src/controller/graph.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/module/synchronized.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/module/synchronized.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/module/synchronized.rs Outdated Show resolved Hide resolved
src/rust/ide/src/view/layout.rs Outdated Show resolved Hide resolved
src/rust/ide/src/view/node_searcher.rs Outdated Show resolved Hide resolved
mwu-tow
mwu-tow reviewed Jul 21, 2020
View reviewed changes
src/rust/ide/tests/language_server.rs Outdated Show resolved Hide resolved
src/rust/ide/lib/parser/src/wsclient.rs Outdated Show resolved Hide resolved
src/rust/ide/lib/parser/src/wsclient.rs Outdated Show resolved Hide resolved
src/rust/ide/src/controller/graph.rs Outdated Show resolved Hide resolved
src/rust/ide/src/controller/module.rs Outdated Show resolved Hide resolved
src/rust/ide/lib/enso-protocol/src/lib.rs Show resolved Hide resolved
src/rust/ide/src/model.rs Show resolved Hide resolved
src/rust/ide/src/model/execution_context.rs Show resolved Hide resolved
src/rust/ide/src/model/execution_context/synchronized.rs Outdated Show resolved Hide resolved
src/rust/ide/src/model/project/synchronized.rs Outdated Show resolved Hide resolved
@mwu-tow mwu-tow merged commit d7d500f into main Jul 21, 2020
@mwu-tow mwu-tow deleted the wip/mwu/refactoring branch July 21, 2020 20:18
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
@farmaazon
Refactoring IDE models. (enso-org/ide#681)
e8d623f 
Co-authored-by: mwu <[email protected]>

Original commit: enso-org/ide@d7d500f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwu-tow mwu-tow mwu-tow left review comments

@wdanilo wdanilo wdanilo approved these changes

Assignees

@mwu-tow mwu-tow

@farmaazon farmaazon

Labels
Category: Controllers The Application layer not bound to visual part Difficulty: Core Contributor Should only be attempted by a core contributor Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farmaazon @CLAassistant @mwu-tow @wdanilo