entgql: make connection node non-null #597
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ent/ent#3998
What's changed
Generates
node
field in connection edge types as non-null types instead of nullable types.Background
According to the spec,
node
field can be non-null.On the other hand,
edges
field in connection types are defined as just a list type that wraps an edge type, which means[Edge]
but not[Edge]!
.So this PR only changes
node
field and keepsedges
field as it is.Concerns
My concern is whether we should consider this a breaking change.
GraphQL API clients can accept the transition from nullable to non-null fields without any change or breaking. How about servers? I'm not sure this change would break server implementations using ent.
If so, we can introduce this change as an option.