New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mob][photos] Fix exceptions from incorrect use of InheritedWidget #3247

Merged

ashilkn merged 2 commits into main from fix_exceptions

Sep 12, 2024

Member

ashilkn commented Sep 12, 2024 •

edited

Loading

Description

Avoid/fix potential and current issues caused due to calling dependOnInheritedWidgetOfExactType<T>() in initState (i.e, before the widget is build).

ashilkn added 2 commits

September 12, 2024 17:04


          [mob][photos] Fix exceptions from calling dependOnInheritedWidgetOfEx…

d976986

…actType in init state


          [mob][photos] Avoid passing text gotten from inherited widget

d649cbd

ashilkn changed the title ~~[mob][photos] Fix exceptions~~ [mob][photos] Fix exceptions from incorrect use of InheritedWidget

ashilkn enabled auto-merge

September 12, 2024 12:14

ua741 approved these changes

View reviewed changes

ashilkn merged commit cc80453 into main

2 checks passed

ashilkn deleted the fix_exceptions branch

September 12, 2024 12:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet