Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pritunl icon #3486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added pritunl icon #3486

wants to merge 1 commit into from

Conversation

AgentT30
Copy link

Added pritunl icon

@ua741 please review

@Eseltwift
Copy link
Contributor

Eseltwift commented Sep 27, 2024

Hey 👋

Allow me to make a few suggestions for improvement.

First, the section on Pritunl should be added between PostNL and Privacy Guides to maintain the alphabetical order of the JSON file.

Additionally, the altNames field is only required if several names can refer to the same logo. Icon names are case insensitive.

Here is an example:

"title": "Battle.net",
"slug": "battlenet",
"altNames": [
  "Battle net",
  "Blizzard"
]

The main/official name is Battle.net, but the file name is different, so we're adding a slug field to point to the correct file. Finally, we can assume that some people will call their entry in a different way, so we're planning alternative names such as Battle net and Blizzard.

So there's no need to add an alternative name in your case, since it's identical (not case-sensitive) to the title field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants