Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] fix x64 installer on arm64 Windows #3502

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

omove
Copy link
Contributor

@omove omove commented Sep 28, 2024

Portable x64 Ente Auth works on arm64 Windows, but the installer version fails due to not supporting arm64. As per Inno Setup's documentation the 'x64' option will only allow installing on x64 Windows, changing to 'x64compatible' allows the x64 installer to work on arm64 as well.

Inno Setup's 'x64' option only allows install on x64 Windows, changing to 'x64compatible' allows x64 installation on arm64 and x64 Windows.
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@prateekmedia prateekmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@prateekmedia prateekmedia merged commit c160afc into ente-io:main Sep 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants