Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build linux_amd64 target for PRs on Tekton #1536

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

zregvart
Copy link
Member

Reference: EC-540

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (6048d47) to head (09e76e4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1536      +/-   ##
==========================================
+ Coverage   80.38%   86.90%   +6.52%     
==========================================
  Files          66       77      +11     
  Lines        4761     5101     +340     
==========================================
+ Hits         3827     4433     +606     
+ Misses        934      668     -266     
Flag Coverage Δ
acceptance 72.09% <ø> (?)
generative 80.38% <ø> (ø)
integration 80.38% <ø> (ø)
unit 80.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

@zregvart
Copy link
Member Author

/retest

@simonbaird
Copy link
Member

simonbaird commented Apr 19, 2024

Nice. This (the build args support) was demoed literally just yesterday, right? We are early adopters!

@simonbaird
Copy link
Member

Logs are gone already, but I could find the image here.

This confirms what platform/arches were built:

podman run -it --rm --entrypoint /bin/bash quay.io/redhat-user-workloads/rhtap-contract-tenant/ec-main-ci/cli-main-ci:on-pr-09e76e458c5a7fa91e83c683f8c5ed5e2dd5e896  -c "ls -l /usr/local/bin"
total 224452
-rwxr-xr-x 1 root root 104977672 Apr 19 13:26 cosign
-rwxr-xr-x 1 root root  95723520 Apr 19 13:26 ec
-rwxr-xr-x 1 root root  29115023 Apr 19 13:26 ec_linux_amd64.gz
-rw-r--r-- 1 root root       119 Apr 19 13:26 ec_linux_amd64.sha256.gz

Lgtm.

@simonbaird simonbaird merged commit 3879741 into enterprise-contract:main Apr 19, 2024
12 checks passed
@zregvart zregvart deleted the issue/EC-540 branch April 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants