Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old index bug in call_with_inout #473

Merged
merged 36 commits into from
Jan 10, 2024
Merged

Fix old index bug in call_with_inout #473

merged 36 commits into from
Jan 10, 2024

Commits on Jan 28, 2023

  1. bugfix in call_with_inout

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    5b81666 View commit details
    Browse the repository at this point in the history

  2. minor cleanup

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    ec13cd2 View commit details
    Browse the repository at this point in the history

  3. handling the case of no in and no out

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    b4e4fb8 View commit details
    Browse the repository at this point in the history

  4. Test case for _fix_inout_args

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    ad4583e View commit details
    Browse the repository at this point in the history

  5. additional cleanup and error handling

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    d2d47f2 View commit details
    Browse the repository at this point in the history

  6. code formatting fixed

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    bd9adfe View commit details
    Browse the repository at this point in the history

  7. fix python 3.7 and 3.8 compatibility

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    dc6446e View commit details
    Browse the repository at this point in the history

  8. Temporary addition of real-world test

    @jonschz
    jonschz authored and Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    c19ff6e View commit details
    Browse the repository at this point in the history

  9. code cleanup

    Jonathan committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    948e5e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. intermediate commit, do not review

    jonschz committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    f26ade5 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Refactor of unit test, removing portdevice test

    @jonschz
    jonschz committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    285571f View commit details
    Browse the repository at this point in the history

  2. fix global side-effect of other skipped test

    @jonschz
    jonschz committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    56adf7b View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Update comtypes/test/test_outparam.py 

    Co-authored-by: Jun Komoda <[email protected]>
    @jonschz @junkmd
    jonschz and junkmd authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    075b00c View commit details
    Browse the repository at this point in the history

  2. work on tests for inout_args and outparam 

    - cleanup for test_outparam.py
- improvements to test_inout_args.py
- comments on a possible error in _memberspec.py
    @jonschz
    jonschz committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    39e20a1 View commit details
    Browse the repository at this point in the history

  3. removing dead code

    @jonschz
    jonschz committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    aed2820 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. rename variables and add assertions

    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    359d103 View commit details
    Browse the repository at this point in the history

  2. pass MagicMock instead of ut.TestCase

    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    f182c74 View commit details
    Browse the repository at this point in the history

  3. make tests for each argument passing patterns

    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    3cf0ae9 View commit details
    Browse the repository at this point in the history

  4. remove duplicated comments

    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    fb65f11 View commit details
    Browse the repository at this point in the history

  5. update test code for readability 

    - remove name from mock
- move line breaks to between mock preparations and assertions
    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    6adaace View commit details
    Browse the repository at this point in the history

  6. split the testcases

    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    27e0cb7 View commit details
    Browse the repository at this point in the history

  7. add Test_Error

    @junkmd
    junkmd committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    8e28b28 View commit details
    Browse the repository at this point in the history

  8. minor corrections, remove redundancy, migration 

    - rewrite the permutations test
- missing direction and omitted name redundant
- migrate autogenerated keywords
- TBD: more real life tests
    @jonschz
    jonschz committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    df58430 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Add tests covering 24 patterns 

    - instead of using `if` statements and `permutations`
    @junkmd
    junkmd committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    522424e View commit details
    Browse the repository at this point in the history

  2. update test name

    @junkmd
    junkmd committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    3b72578 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. add real world tests, remove old code

    @jonschz
    jonschz committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ca5c780 View commit details
    Browse the repository at this point in the history

  2. formatting issue

    @jonschz
    jonschz committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    3af5e90 View commit details
    Browse the repository at this point in the history

  3. Update comtypes/_memberspec.py 

    dict type annotation

Co-authored-by: Jun Komoda <[email protected]>
    @jonschz @junkmd
    jonschz and junkmd authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9076091 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Change missing 'in' or 'out' to be treated as 'in'

    @jonschz
    jonschz committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    12bcdbc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'inout-bug' of https://github.com/jonschz/comtypes into … 

    …inout-bug
    @jonschz
    jonschz committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0b3de9b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Add real-world test: param without 'in' or 'out'

    @jonschz
    jonschz committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    690b9d0 View commit details
    Browse the repository at this point in the history

  2. add contextlib.redirect_stdout 

    to supress warnings
    @junkmd
    junkmd committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    5d3a194 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. apply review feedback

    @jonschz
    jonschz committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    788df7c View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. update comments

    @junkmd
    junkmd committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a928676 View commit details
    Browse the repository at this point in the history

  2. add line breaks to lines longer than 88 characters

    @junkmd
    junkmd committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b2a46eb View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Update comtypes/test/test_inout_args.py

    @junkmd
    junkmd authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    84cd5c8 View commit details
    Browse the repository at this point in the history